fix: bug with graphql nested queries #3089
Conversation
github-actions
bot
added
the
type: fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3089 +/- ##
=======================================
Coverage 86.87% 86.88%
=======================================
Files 276 276
Lines 26873 26923 +50
=======================================
+ Hits 23347 23391 +44
- Misses 3526 3532 +6 ☔ View full report in Codecov by Sentry. |
| ) -> RelatedFields { | ||
| type_names: VecDeque<String>, | ||
| visited: &mut HashSet<VecDeque<String>>, | ||
| ) -> Option<RelatedFields> { |
There was a problem hiding this comment.
| ) -> Option<RelatedFields> { | |
| ) -> Valid<RelatedFields, String> { |
| ) | ||
| .map_err(|e| ValidationError::new(e.to_string())), | ||
| ) | ||
| }) |
There was a problem hiding this comment.
This implementation needs to be changed. The related field information can't be inferred while creating a blueprint. It should be implemented as a part of the JIT transformation step. The JIT Transformations should identify exactly what the RequestTemplate should look like for each query and then while evaluating we should simply use that operation and execute the GraphQL request.
|
Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention. |
|
Action required: PR inactive for 5 days. |
github-actions
bot
added
the
state: inactive
|
PR closed after 10 days of inactivity. |
Summary:
There is a bug when sending a nested query to a graphql server. The bug is described with an example in the issue created.
Issue Reference(s):
Fixes #3088
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>